YounHS commented on code in PR #39355: URL: https://github.com/apache/airflow/pull/39355#discussion_r1650226923
########## airflow/www/static/js/toggle_theme.js: ########## @@ -0,0 +1,44 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* global document, localStorage, window */ + +const STORAGE_THEME_KEY = "darkTheme"; +const HTML_THEME_DATASET_KEY = "data-color-scheme"; +const HTML = document.documentElement; +const TOGGLE_BUTTON_ID = "themeToggleButton"; + +const getJsonFromStorage = (key) => JSON.parse(localStorage.getItem(key)); +const updateTheme = (isDark) => { + localStorage.setItem(STORAGE_THEME_KEY, isDark); + HTML.setAttribute(HTML_THEME_DATASET_KEY, isDark ? "dark" : "light"); +}; +const initTheme = () => { + const isDark = getJsonFromStorage(STORAGE_THEME_KEY); + if (isDark !== null) updateTheme(isDark); +}; +const toggleTheme = () => { + const isDark = getJsonFromStorage(STORAGE_THEME_KEY); + updateTheme(!isDark); +}; +window.addEventListener("click", (e) => { + if (e.target.id !== TOGGLE_BUTTON_ID) return; Review Comment: That's a Good for performance. I guess it's better to specify only the themeToggleButton listener than to listen to all click events! But one thing. I'm trying to use the DOMContentLoaded listener in the code you suggested. If you don't use the DOMContentLoaded listener, the JS will not find the themeToggleButton element. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
