potiuk commented on code in PR #40588:
URL: https://github.com/apache/airflow/pull/40588#discussion_r1664391760


##########
docs/build_docs.py:
##########
@@ -450,6 +450,14 @@ def main():
         for pkg in sorted(available_packages):
             console.print(f" - {pkg}")
 
+    for package in available_packages:
+        api_dir = os.path.join(DOCS_DIR, package, "_api")
+        if os.path.exists(api_dir):

Review Comment:
   I think this should also include check if the `_api` folder is empty. 
Otherwise this warning will be printed always when the `_api` folder is present 
- and this is generally "always" present after first build (but it contains 
generated documentation),
   
   I **believe** the problem we are experiencing with "nonexisting document" 
only happens when we stopped (with ctrl+c) generation of the documentaion or 
when some specific errors occur during generation of the `_api` documentation - 
and I think (or at least that was my observation before) that in both cases no 
.rst files were generated, but the empty `_api`  folder remained.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to