dolfinus commented on PR #40854:
URL: https://github.com/apache/airflow/pull/40854#issuecomment-2236466647
> Added to AirflowJobFacet that we attach to DagRun events.
DagRun information is a part of RunFacet, and cannot be JobFacet.
> I think this should be a different facet
Is that okay if facet with key `"airflow"` will have different schema for
DAG and Task?
Honestly, I'd rather split these fields to different facets, like:
```yaml
job:
facets:
airflow_dag: AirflowDagJobFacet(...) # previously airflow:dag
airflow_task: AirflowTaskJobFacet(...) # previously airflow:task
run:
facets:
airflow_dagRun: AirflowDagRunFacet(...) # previously airflow:dagRun
airflow_taskInstance: AirflowTaskInstanceFacet(...) # previously
airflow:taskInstance
# throw away taskUuuid, it just ruplicates runId
```
But this is not backwards compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
