softyoungha commented on PR #40775: URL: https://github.com/apache/airflow/pull/40775#issuecomment-2237972325
@potiuk To summarize: - It does not align with Airflow's security aims for. - Users managing connections via UI can make side effects to DAG codes. - Since requirements are not located in the code, no traceability on requirements. - Unlike the concept of "Connection" handling external system parameters, it directly intervenes in the environment. - Expanding the interface with connections may expose the system to attacks. - Even if permissions are set per connection, having them located there is inherently problematic. I may have been mistaken about some aspects of security, because I was working as both a DAG Author and a Deploy Manager when using Airflow. Typically, once batch jobs are developed to a certain extent, the requirements are fixed, and we used them consistently. Thanks to the virtual environment's cache functionality, I considered it akin to an external system. If this feature does not align with the core concept of Airflow, it is okay if it is not merged. :) @jscheffl Thank you for the detailed review! I think I'm getting way too hung up on how SparkSubmitOperator & Hook are implemented. but as you mentioned, it is best not to change Airflow’s core feature. If it is decided to proceed further with the PR, I will make the adjustments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
