dolfinus commented on code in PR #40854:
URL: https://github.com/apache/airflow/pull/40854#discussion_r1686247089
##########
airflow/providers/openlineage/plugins/adapter.py:
##########
@@ -329,19 +330,26 @@ def dag_started(
self,
dag_run: DagRun,
msg: str,
- nominal_start_time: str,
- nominal_end_time: str,
Review Comment:
Reverted.
But IMHO to be a public api this method should be at least properly
documented. And maybe even redesigned, as it currently accepts DagRun, unlike
other methods which do not accept Airflow models, but instead set of separated
fields to just build OpenLineage events from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
