potiuk commented on PR #40916:
URL: https://github.com/apache/airflow/pull/40916#issuecomment-2248139951

   > @potiuk @kosteev FYI I have run these changes with breeze env for checking 
the DB queries count function. And after these changes we have the same number, 
is 5, for each DAG file, before these changes each DAG file has a different 
number. I think these changes somehow broke our Last # of DB Queries stats.
   
   Yeah. The whole DAG parsing is now "outside" of the context manager. And I 
am quite baffled to why the session would be used even if it is not passed 
down. It should get fixed if we wrap DAG parsing with the session (again 
conditionally on internal_api) and possibly even more accurate if that wrapping 
is done with the engine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to