shahar1 commented on code in PR #41054:
URL: https://github.com/apache/airflow/pull/41054#discussion_r1693417148
##########
airflow/providers/apprise/notifications/apprise.py:
##########
@@ -52,9 +51,9 @@ def __init__(
*,
body: str,
title: str | None = None,
- notify_type: NotifyType | None = None,
- body_format: NotifyFormat | None = None,
- tag: str | Iterable[str] | None = None,
+ notify_type: NotifyType = NotifyType.INFO,
+ body_format: NotifyFormat = NotifyFormat.TEXT,
+ tag: str | Iterable[str] = "all",
Review Comment:
It seems like a breaking change - theoretically, someone could init. the
class with either `notify_type=None, body_format=None, tag=None` and it will
fail.
I suggest deprecating it gradually, i.e. - if any of the params is `None` -
raise a deprecation warning + assign the corresponding default).
##########
airflow/providers/apprise/hooks/apprise.py:
##########
@@ -74,7 +74,7 @@ def notify(
title: str | None = None,
notify_type: NotifyType = NotifyType.INFO,
body_format: NotifyFormat = NotifyFormat.TEXT,
- tag: str | Iterable[str] | None = None,
+ tag: str | Iterable[str] = "all",
Review Comment:
Same comment regarding the breaking change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
