raphaelauv commented on code in PR #40924: URL: https://github.com/apache/airflow/pull/40924#discussion_r1693641088
########## airflow/sensors/base.py: ########## @@ -114,15 +118,33 @@ def _orig_start_date( ) +class SkipPolicy(str, enum.Enum): + """Class with sensor's skip policies.""" + + # if poke method raise an exception, sensor will not be skipped on. + NONE = "none" + + # If poke method raises an exception, sensor will be skipped on. + SKIP_ON_ANY_ERROR = "skip_on_any_error" + + # If poke method raises AirflowSensorTimeout, AirflowTaskTimeout, AirflowFailException + # sensor will be skipped on. + SKIP_ON_SOFT_ERROR = "skip_on_soft_error" Review Comment: what about SKIP_ON_TIMEOUT and remove AirflowFailException from the list of exception catch by this option naming would be explicit and correct wdyt ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org