shahar1 commented on code in PR #41103:
URL: https://github.com/apache/airflow/pull/41103#discussion_r1695717877
##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -1382,30 +1382,30 @@ def execute(self, context: Context, event: dict[str,
Any] | None = None) -> str
self.persist_links(context)
- if self.deferrable:
- self.defer(
- trigger=EmrServerlessStartJobTrigger(
- application_id=self.application_id,
- job_id=self.job_id,
- waiter_delay=self.waiter_delay,
- waiter_max_attempts=self.waiter_max_attempts,
- aws_conn_id=self.aws_conn_id,
- ),
- method_name="execute_complete",
- timeout=timedelta(seconds=self.waiter_max_attempts *
self.waiter_delay),
- )
-
if self.wait_for_completion:
- waiter = self.hook.get_waiter("serverless_job_completed")
- wait(
- waiter=waiter,
- waiter_max_attempts=self.waiter_max_attempts,
- waiter_delay=self.waiter_delay,
- args={"applicationId": self.application_id, "jobRunId":
self.job_id},
- failure_message="Serverless Job failed",
- status_message="Serverless Job status is",
- status_args=["jobRun.state", "jobRun.stateDetails"],
- )
+ if self.deferrable:
Review Comment:
Is it possible to add a unit test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
