o-nikolas commented on code in PR #41107:
URL: https://github.com/apache/airflow/pull/41107#discussion_r1695976549
##########
airflow/executors/base_executor.py:
##########
@@ -288,7 +288,8 @@ def _emit_metrics(self, open_slots, num_running_tasks,
num_queued_tasks):
self.log.debug("%s running task instances for executor %s",
num_running_tasks, name)
self.log.debug("%s in queue for executor %s", num_queued_tasks, name)
if open_slots == 0:
- self.log.info("Executor parallelism limit reached. 0 open slots.")
+ if self.parallelism:
Review Comment:
FYI @BasPH
You changed the below log to info, and when parallelism is 0 this gets
logged every single heartbeat because the open slots calculation in the sync
method above doesn't account for that case very well. I didn't want to tackle
that case just yet, because it would be kind of a breaking change for the
metrics in that case (they would start reporting "infinity" open slots). So I
went with not emitting that metrics if we see zero slots (nothing queued) and
parallelism is zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
