raphaelauv commented on code in PR #41047: URL: https://github.com/apache/airflow/pull/41047#discussion_r1701519704
########## tests/sensors/test_external_task_sensor.py: ########## @@ -30,14 +30,25 @@ from airflow import exceptions, settings from airflow.decorators import task as task_deco -from airflow.exceptions import AirflowException, AirflowSensorTimeout, AirflowSkipException, TaskDeferred +from airflow.exceptions import ( + AirflowException, + AirflowPokeFailException, + AirflowSensorTimeout, + AirflowSkipException, + TaskDeferred, +) from airflow.models import DagBag, DagRun, TaskInstance from airflow.models.dag import DAG from airflow.models.serialized_dag import SerializedDagModel from airflow.models.xcom_arg import XComArg from airflow.operators.bash import BashOperator from airflow.operators.empty import EmptyOperator from airflow.operators.python import PythonOperator +from tests.test_utils.compat import AIRFLOW_V_2_10_PLUS, ignore_provider_compatibility_error + +with ignore_provider_compatibility_error("2.10.0", __file__): Review Comment: the compatibility test fail cause lower version of airflow do not ignore theses imports , do you know why ? ```shell breeze shell --use-airflow-version 2.9.1 --mount-sources providers-and-tests pytest tests/providers/sftp/ ``` give ``` ImportError: cannot import name 'FailPolicy' from 'airflow.sensors.base' (/usr/local/lib/python3.8/site-packages/airflow/sensors/base.py) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org