vincbeck commented on code in PR #41380:
URL: https://github.com/apache/airflow/pull/41380#discussion_r1713934095


##########
airflow/providers/amazon/aws/operators/eks.py:
##########
@@ -1100,4 +1108,22 @@ def execute(self, context: Context):
         with eks_hook.generate_config_file(
             eks_cluster_name=self.cluster_name, pod_namespace=self.namespace
         ) as self.config_file:
+            if self.deferrable:

Review Comment:
   You are waiting before actually executing the task? Also, you need to check 
`wait_for_completion`, if `wait_for_completion` is `False` you do not want to 
wait. `wait_for_completion` configures whether the operator wait for a given 
status, `deferrable` configures how to wait (if `wait_for_completion` is 
`True`): in poke mode or deferrable mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to