potiuk commented on PR #40421: URL: https://github.com/apache/airflow/pull/40421#issuecomment-2297179570
I am not sure what exactly problem with if != "" was (because it is slightly not precise - and the exact scemario described in #23241 does not explain it in detail - but I guess if we won't check it, we can accidentally modify fields when they are removed between the connections. I tried to follow the scenario described in #23241 but I could not see anything wrong with it. This whole Connection editing form will have to be recreated in Airflow 3 - and I just realized that just few days ago https://github.com/apache/airflow/pull/41144 has been merged that will show the warning in 2.10.1 that in order to remove values you need to recreate the connection - while not perfect - I would hesitate to merge this one until we are sure what was the reason and scenario we wanted to protect (@josh-fell @dstandish - maybe you will be able to dig it out - I know it's 2 years old, but there was a discussion about the if and it apparently made sense then). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
