topherinternational commented on code in PR #41555: URL: https://github.com/apache/airflow/pull/41555#discussion_r1724076743
########## airflow/providers/cloudant/cloudant_fake.py: ########## Review Comment: @eladkal @potiuk so this is a big hack...static tests were failing bc we run static tests on Pyhton 3.8, but we exclude the provider on 3.8, so the container doesn't have the ibmcloudant package installed and the module fails to evaluate. So I added a version detection block that imports a fake version of the couldant classes on 3.8 and 3.9. I leave it to you to decide if you want to have this kind of mess in your codebase 😅 . I'm not sure if exclusions of the lowest-supported Python version is feasible without something like this to keep the code from being eval'd at all in the static tests and doc tasks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
