o-nikolas commented on code in PR #41904:
URL: https://github.com/apache/airflow/pull/41904#discussion_r1740149478
##########
airflow/providers/celery/executors/celery_kubernetes_executor.py:
##########
@@ -30,18 +31,21 @@
raise AirflowOptionalProviderFeatureException(e)
-from airflow.utils.log.logging_mixin import LoggingMixin
from airflow.utils.providers_configuration_loader import
providers_configuration_loaded
if TYPE_CHECKING:
from airflow.callbacks.base_callback_sink import BaseCallbackSink
from airflow.callbacks.callback_requests import CallbackRequest
- from airflow.executors.base_executor import CommandType,
EventBufferValueType, QueuedTaskInstanceType
+ from airflow.executors.base_executor import (
+ CommandType,
+ EventBufferValueType,
+ QueuedTaskInstanceType,
+ )
from airflow.models.taskinstance import SimpleTaskInstance, TaskInstance
from airflow.models.taskinstancekey import TaskInstanceKey
-class CeleryKubernetesExecutor(LoggingMixin):
+class CeleryKubernetesExecutor(BaseExecutor):
Review Comment:
To me this abomination isn't an executor, only the sub executors are valid
executors. But also, they won't last long until they're removed so I suppose
it's not a big deal either way! Happy to approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
