nevcohen commented on code in PR #40757:
URL: https://github.com/apache/airflow/pull/40757#discussion_r1741069969
##########
airflow/providers/apache/spark/hooks/spark_submit.py:
##########
@@ -236,6 +257,8 @@ def _resolve_connection(self) -> dict[str, Any]:
"deploy_mode": None,
"spark_binary": self.spark_binary or DEFAULT_SPARK_BINARY,
"namespace": None,
+ "principal": None,
+ "keytab": None,
Review Comment:
I meant what about there are several different principles, since you only
override the user from the connection if he has not entered a principle, this
is correct and it will be possible to use several different principles on the
same queue.
So I approve this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
