bbovenzi commented on PR #1062: URL: https://github.com/apache/airflow-site/pull/1062#issuecomment-2341566271
> I checked the diff w/o whitespace... ![image](https://private-user-images.githubusercontent.com/95105677/366140747-c11cf25d-d747-4700-910e-544649b4fa13.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5ODk5NjYsIm5iZiI6MTcyNTk4OTY2NiwicGF0aCI6Ii85NTEwNTY3Ny8zNjYxNDA3NDctYzExY2YyNWQtZDc0Ny00NzAwLTkxMGUtNTQ0NjQ5YjRmYTEzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDE3MzQyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMxOTQ1NGY1MDIzMmRlZDA2OTgyNzY2Yjk3YTA5YzJjM2NlZWFlNWE3YTcyNzA4MDA0ZjgzYzRhYjE5ODkwYTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.-cSx1v2ihkj8vUunI2E3tIK1QBqLyyMS185Dab08YYE) > > Is the build testable in a different URL? Actually this PR mixed a bit of sticky layout changes with adding a menu entry. Next time might be easier to separate. > > From point of code view... seems reasonable. Oh I never noticed that option before. This generally looks good to me. It would still be best not to contribute whitespace changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org