vincbeck commented on code in PR #42218:
URL: https://github.com/apache/airflow/pull/42218#discussion_r1761338541
##########
airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -97,6 +98,8 @@ def __init__(
return_sql_result: bool = False,
workgroup_name: str | None = None,
deferrable: bool = conf.getboolean("operators", "default_deferrable",
fallback=False),
+ session_id: str | None = None,
+ session_keep_alive_seconds: int | None = None,
Review Comment:
Please add them to docstring
##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -76,7 +88,9 @@ def execute_query(
wait_for_completion: bool = True,
poll_interval: int = 10,
workgroup_name: str | None = None,
- ) -> str:
+ session_id: str | None = None,
+ session_keep_alive_seconds: int | None = None,
+ ) -> QueryExecutionOutput:
Review Comment:
This is a breaking change. Users who are using
`RedshiftDataHook.execute_query` will have their DAG fail with this change. I
dont have a solution though (besides creating a new operator which I really
dont like). Or maybe creating a new major version is fine? It has been a while
we have not cut a new major release of the Amazon provider package. @o-nikolas
@ferruzzi ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
