ashb commented on code in PR #41984:
URL: https://github.com/apache/airflow/pull/41984#discussion_r1776985494
##########
scripts/ci/pre_commit/check_deferrable_default.py:
##########
@@ -33,62 +37,71 @@
)
+class DefaultDeferrableVisitor(ast.NodeVisitor):
+ def __init__(self, *args, **kwargs) -> None:
+ super().__init__(*args, *kwargs)
+ self.error_linenos: list[int] = []
+
+ def visit_FunctionDef(self, node: ast.FunctionDef) -> ast.FunctionDef:
+ if node.name == "__init__":
+ args = node.args
+ arguments = reversed([*args.args, *args.posonlyargs,
*args.kwonlyargs])
+ defaults = reversed([*args.defaults, *args.kw_defaults])
+ for argument, default in itertools.zip_longest(arguments,
defaults):
+ # argument is not deferrable
+ if argument is None or argument.arg != "deferrable":
+ continue
+
+ # argument is deferrable, but comes with no default value
+ if default is None:
+ self.error_linenos.append(argument.lineno)
+ continue
+
+ # argument is deferrable, but the default value is not valid
+ if not _is_valid_deferrable_default(default):
+ self.error_linenos.append(default.lineno)
+ return node
+
+
+class DefaultDeferrableTransformer(cst.CSTTransformer):
+ def leave_Param(self, original_node: cst.Param, updated_node: cst.Param)
-> cst.Param:
+ if original_node.name.value == "deferrable":
+ expected_default_cst = cst.parse_expression(
+ 'conf.getboolean("operators", "default_deferrable",
fallback=False)'
+ )
+
+ if updated_node.default and
updated_node.default.deep_equals(expected_default_cst):
+ return updated_node
+ return updated_node.with_changes(default=expected_default_cst)
+ return updated_node
+
+
def _is_valid_deferrable_default(default: ast.AST) -> bool:
"""Check whether default is 'conf.getboolean("operators",
"default_deferrable", fallback=False)'"""
- if not isinstance(default, ast.Call):
- return False # Not a function call.
-
- # Check the function callee is exactly 'conf.getboolean'.
- call_to_conf_getboolean = (
- isinstance(default.func, ast.Attribute)
- and isinstance(default.func.value, ast.Name)
- and default.func.value.id == "conf"
- and default.func.attr == "getboolean"
- )
- if not call_to_conf_getboolean:
- return False
-
- # Check arguments.
- return (
- len(default.args) == 2
- and isinstance(default.args[0], ast.Constant)
- and default.args[0].value == "operators"
- and isinstance(default.args[1], ast.Constant)
- and default.args[1].value == "default_deferrable"
- and len(default.keywords) == 1
- and default.keywords[0].arg == "fallback"
- and isinstance(default.keywords[0].value, ast.Constant)
- and default.keywords[0].value.value is False
- )
+ return ast.unparse(default) == "conf.getboolean('operators',
'default_deferrable', fallback=False)"
Review Comment:
This also needs Python 3.9 to work, it didn't exist before there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]