[ https://issues.apache.org/jira/browse/AIRFLOW-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930112#comment-16930112 ]
ASF GitHub Bot commented on AIRFLOW-5490: ----------------------------------------- jghoman commented on pull request #6109: [AIRFLOW-5490] Fix incorrect None comparison URL: https://github.com/apache/airflow/pull/6109 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > security.py: Fix incorrect None comparison > ------------------------------------------ > > Key: AIRFLOW-5490 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5490 > Project: Apache Airflow > Issue Type: Bug > Components: security > Affects Versions: 1.10.6 > Reporter: Jakob Homan > Priority: Minor > Labels: ccoss2019, newbie > > Note: This ticket's being created to facilitate a new contributor's workshop > for Airflow. After the workshop has completed, I'll mark these all available > for anyone that might like to take them on. > In security.py, we twice use ``==`` with ``None``, which is [not > correct|https://stackoverflow.com/a/3257957] > airflow/www/security.py:343 > {code:python} > sqla_models.PermissionView.permission == None, # noqa pylint: > disable=singleton-comparison > sqla_models.PermissionView.view_menu == None, # noqa pylint: > disable=singleton-comparison > )) {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)