jason810496 commented on code in PR #42902:
URL: https://github.com/apache/airflow/pull/42902#discussion_r1796744313
##########
tests/utils/test_file.py:
##########
@@ -212,3 +213,26 @@ def test_get_modules_from_invalid_file(self):
modules = list(file_utils.iter_airflow_imports(file_path))
assert len(modules) == 0
+
+
+def test_get_unique_dag_module_name():
+ edge_filenames = [
+ "test_dag.py",
+ "test-dag.py",
+ "test-dag-1.py",
+ "test-dag_1.py",
+ "test-dag.dev.py",
+ "test_dag.prod.py",
+ ]
+ # sha1 of file_path in middle
+ expected_regex = [
+ r"unusual_prefix_[0-9a-f]{40}_test_dag",
+ r"unusual_prefix_[0-9a-f]{40}_test_dag",
+ r"unusual_prefix_[0-9a-f]{40}_test_dag_1",
+ r"unusual_prefix_[0-9a-f]{40}_test_dag_1",
+ r"unusual_prefix_[0-9a-f]{40}_test_dag_dev",
+ r"unusual_prefix_[0-9a-f]{40}_test_dag_prod",
+ ]
Review Comment:
Since
[`get_unique_dag_module_name`](https://github.com/apache/airflow/blob/main/airflow/utils/file.py#L357)
returns a unique module name in the format `unusual_prefix_{sha1 of module's
file path}_{original module name}`, and I can't mock the path hash since the
hash part is coupled within `get_unique_dag_module_name`, I used a regex to
validate the expected result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
