bbovenzi commented on code in PR #43093:
URL: https://github.com/apache/airflow/pull/43093#discussion_r1803617729
##########
airflow/ui/rules/perfectionist.js:
##########
@@ -128,16 +119,21 @@ export const perfectionistRules =
/**
* Enforce sorted TypeScript union types.
*
- * @see
[perfectionist/sort-union-types](https://perfectionist.dev/rules/sort-union-types)
- */
- [`${perfectionistNamespace}/sort-union-types`]: ERROR,
-
- /**
- * Enforce sorted attributes in Vue elements.
+ * nullish groups will leave null and undefined at the end
*
- * @see
[perfectionist/sort-vue-attributes](https://perfectionist.dev/rules/sort-vue-attributes)
+ * @see
[perfectionist/sort-union-types](https://perfectionist.dev/rules/sort-union-types)
*/
- [`${perfectionistNamespace}/sort-vue-attributes`]: ERROR,
+ [`${perfectionistNamespace}/sort-union-types`]: [
+ ERROR,
+ {
+ groups: [
+ ["conditional", "function", "import"],
+ ["intersection", "keyword", "named"],
+ ["literal", "object", "operator", "tuple", "union"],
+ "nullish",
Review Comment:
Improved union order with nullish and unknown always at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
