ephraimbuddy commented on code in PR #42913:
URL: https://github.com/apache/airflow/pull/42913#discussion_r1803839168
##########
airflow/models/dag.py:
##########
@@ -2463,7 +2471,7 @@ def create_dagrun(
conf: dict | None = None,
run_type: DagRunType | None = None,
session: Session = NEW_SESSION,
- dag_hash: str | None = None,
+ dag_version_id: int | None = None,
Review Comment:
> I am thinking about a backup/restore, how can we be sure durch such cases
the IDs will not overwrite each other?
Since it's a foreign key, I don't see how it will overwrite. The above code
is just for creating the dag version. Maybe we should change it to the
dag_version object itself and not the ID?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
