ashb commented on code in PR #43076:
URL: https://github.com/apache/airflow/pull/43076#discussion_r1804367599
##########
airflow/task/priority_strategy.py:
##########
@@ -150,5 +148,5 @@ def validate_and_load_priority_weight_strategy(
priority_weight_strategy_class = qualname(priority_weight_strategy)
loaded_priority_weight_strategy =
_get_registered_priority_weight_strategy(priority_weight_strategy_class)
if loaded_priority_weight_strategy is None:
- raise AirflowException(f"Unknown priority strategy
{priority_weight_strategy_class}")
+ raise ValueError(f"Unknown priority strategy
{priority_weight_strategy_class}")
Review Comment:
Perhaps yes. The main reason I made this sort of change was to not have to
import airflow.exceptions into the SDK, but that ship has already sailed, so I
will pull this out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
