[
https://issues.apache.org/jira/browse/AIRFLOW-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931338#comment-16931338
]
ASF subversion and git services commented on AIRFLOW-5343:
----------------------------------------------------------
Commit bc826070e15658cc182da5091b6a0f26eb2bc141 in airflow's branch
refs/heads/master from Igor Khrol
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=bc82607 ]
[AIRFLOW-5343] Remove legacy way of pessimistic disconnect handling (#6034)
Based on discussions in https://github.com/apache/airflow/pull/5949
it was figured out that there is already pessimistic disconnect
timeout handling. So instead of hand-written one only SQLAlchemy
embedded way should be used.
'sqlalchemy~=1.3' is in `setup.py` requirements and `pool_pre_ping`
appeared in SQLAlchemy 1.2.
> pool_pre_ping support for SQLAlchemy connection
> -----------------------------------------------
>
> Key: AIRFLOW-5343
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5343
> Project: Apache Airflow
> Issue Type: Task
> Components: configuration
> Affects Versions: 1.10.4
> Reporter: Igor Khrol
> Priority: Minor
> Fix For: 1.10.6
>
>
> SQLalchemy supports connection check while returning it from the pool. There
> is a need to allow this parameter (`pool_pre_ping`) while creating the
> connection to database.
>
> [https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic]
> [https://github.com/apache/airflow/blob/master/airflow/settings.py#L189]
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
