potiuk commented on issue #43379:
URL: https://github.com/apache/airflow/issues/43379#issuecomment-2444993422

   > You have already Reviewed and approved my code when will the PR be merged 
actually its my first PR....
   
   The tests need to pass. As a first time contributor - someone needs to 
approve your "CI" workflows - that's why pinging it in your PR is the best way 
to drag attention to it. Simply "please approve and run my workflow here" in 
the PR will do. And again - any one of maintainers can do it - it does not have 
to be me. I might be on holidays, have vacations or simply be busy with 100 
other prs :)
   
   And it will be merged when it gets green - then you can also write "Hey my 
PR is green, can it be merged" - either in PR or in slack - with link to your 
PR. Doing it in PR makes it ... easier than an issue - because in here you 
might not easily see which PR you are asking for - you need to scroll the 
conversation all the way up and see "may be fixed by ...." so pinging in the PR 
is just ...  more efficient. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to