ephraimbuddy commented on code in PR #42913:
URL: https://github.com/apache/airflow/pull/42913#discussion_r1824097760
##########
providers/tests/fab/auth_manager/api_endpoints/test_backfill_endpoint.py:
##########
@@ -188,7 +188,7 @@ class TestCreateBackfill(TestBackfillEndpoint):
def test_create_backfill(self, session, dag_maker):
with dag_maker(session=session, dag_id="TEST_DAG_1", schedule="0 * * *
*") as dag:
EmptyOperator(task_id="mytask")
- session.add(SerializedDagModel(dag))
+ SerializedDagModel.write_dag(dag)
Review Comment:
I used it a lot without the session in the test. Does it matter, if yes,
happy to change it in all places but I think it does not matter in tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
