vincbeck commented on code in PR #43826:
URL: https://github.com/apache/airflow/pull/43826#discussion_r1834534839
##########
task_sdk/src/airflow/sdk/definitions/dag.py:
##########
@@ -557,9 +557,9 @@ def __lt__(self, other):
def __hash__(self):
hash_components: list[Any] = [type(self)]
for c in _DAG_HASH_ATTRS:
- # task_ids returns a list and lists can't be hashed
- if c == "task_ids":
- val = tuple(self.task_dict)
+ # If it is a list, convert to tuple because lists can't be hashed
Review Comment:
@ashb I made this more generic since `watchers` is also a list and I thought
we could just say "if it is a list, then let's convert it to a tuple". Let me
know if you have any concerns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
