This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new de881827009 #43252 Disable extra links button if link is null or empty
(#43844)
de881827009 is described below
commit de8818270095d9f05edfec8e03daa5df7d6a773b
Author: enisnazif <[email protected]>
AuthorDate: Sat Nov 9 17:40:54 2024 +0000
#43252 Disable extra links button if link is null or empty (#43844)
* Disable button if link is null or empty
* Fix space
---------
Co-authored-by: Enis Nazif <[email protected]>
---
airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
b/airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
index ec44cd920d1..abed8531892 100644
--- a/airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
+++ b/airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
@@ -55,7 +55,7 @@ const ExtraLinks = ({
const isSanitised = (url: string | null) => {
if (!url) {
- return true;
+ return false; // Empty or null urls should cause the link to be disabled
}
const path = new URL(url, "http://localhost";);
// Allow Absolute/Relative URL and prevent javascript:() from executing
when passed as path.
