mrk-andreev commented on code in PR #43853:
URL: https://github.com/apache/airflow/pull/43853#discussion_r1838970301
##########
providers/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -565,6 +585,31 @@ def _reconcile_requested_log_containers(
self.log.error("Could not retrieve containers for the pod: %s",
pod_name)
return containers_to_log
+ def fetch_requested_init_container_logs(
Review Comment:
> does it really make sense to add a new method
fetch_requested_init_container_logs?
Init containers runs sequencially and require different logic for fetching.
For example it is better to fetch logs in order that they are definied
```
# sort by spec.initContainers because containers runs sequentially
containers_to_log = sorted(containers_to_log, key=lambda cn:
all_containers.index(cn))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
