dstandish commented on code in PR #43853:
URL: https://github.com/apache/airflow/pull/43853#discussion_r1840607221
##########
providers/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -692,6 +737,12 @@ def read_pod_logs(
post_termination_timeout=post_termination_timeout,
)
+ @tenacity.retry(stop=tenacity.stop_after_attempt(3),
wait=tenacity.wait_exponential(), reraise=True)
+ def get_init_container_names(self, pod: V1Pod) -> list[str]:
+ """Return container names from the POD except for the
airflow-xcom-sidecar container."""
+ pod_info = self.read_pod(pod)
Review Comment:
The thing is, I'm not telling you what to change. It's not my job to tell
you exactly how to code up your feature. That would take a lot of my time.
I'm spotting a concern, and asking you a question about your code (you are
adding something new, so yes, it is now _your_ code). You seem to keep
dismissing the question. You still don't seem to want to engage with your own
code and give me an opinion on whether it is necessary. That is what I'm
asking you to do. I guess we're having trouble communicating. Please try to
be responsive to my question, which is simply, is there really a need to read
that pod again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
