tirkarthi commented on PR #43888: URL: https://github.com/apache/airflow/pull/43888#issuecomment-2476003286
Thanks @bbovenzi for the feedback. Made the below changes as per latest review. 1. Simple skeleton for dagrun and task instance sections. A better one would be using `SkeletonCircle` for badge and `SkeletonText` for the bar for each state in https://www.chakra-ui.com/docs/components/skeleton . I can take it up in another PR since it's not urgent.  2. I have refactored the datetime selector into a separate component. I would like to access the state changes to `startDate` and `endDate` to pass to API. I had tried to use the pattern as per state lifting docs. Please let me know if there is any other correct approach. https://react.dev/learn/sharing-state-between-components . 3. I will make the changes related to `end_date` being null once the PR changes are merged and not to block this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
