amoghrajesh commented on code in PR #44173:
URL: https://github.com/apache/airflow/pull/44173#discussion_r1850269564
##########
chart/templates/scheduler/scheduler-serviceaccount.yaml:
##########
@@ -23,7 +23,6 @@
{{- if and .Values.scheduler.enabled .Values.scheduler.serviceAccount.create }}
apiVersion: v1
kind: ServiceAccount
-automountServiceAccountToken: {{
.Values.scheduler.serviceAccount.automountServiceAccountToken }}
Review Comment:
These are the possible cases:
1. We can set it to true for cases when it is not CeleryExecutor
2. For other cases it has to be true or the key can be removed entirely.
Two possible approaches. Either control addition or removal of key based on
the executor, otherwise allow to override only for CeleryExecutor
##########
chart/templates/scheduler/scheduler-serviceaccount.yaml:
##########
@@ -23,7 +23,6 @@
{{- if and .Values.scheduler.enabled .Values.scheduler.serviceAccount.create }}
apiVersion: v1
kind: ServiceAccount
-automountServiceAccountToken: {{
.Values.scheduler.serviceAccount.automountServiceAccountToken }}
Review Comment:
These are the possible cases:
1. We can set it to true for cases when it is not CeleryExecutor
2. For other cases it has to be true or the key can be removed entirely.
Two possible approaches. Either control addition or removal of key based on
the executor, otherwise allow to override only for CeleryExecutor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
