pierrejeambrun commented on code in PR #44383:
URL: https://github.com/apache/airflow/pull/44383#discussion_r1862582636
##########
airflow/ui/openapi-gen/requests/types.gen.ts:
##########
@@ -684,7 +684,7 @@ export type HealthInfoSchema = {
metadatabase: BaseInfoSchema;
scheduler: SchedulerInfoSchema;
triggerer: TriggererInfoSchema;
- dag_processor: DagProcessorInfoSchema;
+ dag_processor?: DagProcessorInfoSchema | null;
Review Comment:
If DagProcessor is defined, I don't think it can be actually 'null' can it ?
##########
airflow/ui/src/pages/Dashboard/Health/Health.tsx:
##########
@@ -54,15 +54,14 @@ export const Health = () => {
status={data?.triggerer.status}
title="Triggerer"
/>
- {/* TODO: Update this to match the API when we move the config check
to the API level */}
- {data?.dag_processor.status === undefined ? undefined : (
+ {data && "dag_processor" in data ? (
<HealthTag
isLoading={isLoading}
- latestHeartbeat={data.dag_processor.latest_dag_processor_heartbeat}
- status={data.dag_processor.status}
+
latestHeartbeat={data.dag_processor?.latest_dag_processor_heartbeat}
+ status={data.dag_processor?.status}
title="Dag Processor"
/>
- )}
+ ) : undefined}
Review Comment:
I still have the old diff on my end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
