mfatemipour commented on code in PR #41995:
URL: https://github.com/apache/airflow/pull/41995#discussion_r1863739240
##########
airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx:
##########
@@ -57,8 +57,15 @@ const ExtraLinks = ({
if (!url) {
return true;
}
- const urlRegex = /^(https?:)/i;
- return urlRegex.test(url);
+ const path = new URL(url, "http://localhost";);
Review Comment:
@utkarsharma2
I believe we should use the value from AIRFLOW__WEBSERVER__BASE_URL in
configs, instead of localhost, and this change needs to be backported to
version 2.10
Of course I know this change is already merged, I will create a PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
