jscheffl commented on code in PR #44540:
URL: https://github.com/apache/airflow/pull/44540#discussion_r1864961503


##########
airflow/models/taskinstance.py:
##########
@@ -2558,12 +2508,6 @@ def _check_and_change_state_before_execution(
 
         if isinstance(task_instance, TaskInstance):

Review Comment:
   Is that `if` still needed if there is no else?



##########
providers/src/airflow/providers/amazon/aws/transfers/google_api_to_s3.py:
##########
@@ -175,19 +174,15 @@ def _load_data_to_s3(self, data: dict) -> None:
             replace=self.s3_overwrite,
         )
 
-    def _update_google_api_endpoint_params_via_xcom(
-        self, task_instance: TaskInstance | TaskInstancePydantic
-    ) -> None:
+    def _update_google_api_endpoint_params_via_xcom(self, task_instance: 
TaskInstance) -> None:

Review Comment:
   As you change the signature in Google provider - will this not break 
compatibility of the provider with Airflow 2.10? Here I only see Type checking 
code... mhm, so functional should be working.



##########
airflow/sensors/base.py:
##########
@@ -230,7 +256,7 @@ def execute(self, context: Context) -> Any:
                         TaskReschedule.run_id == ti.run_id,
                         TaskReschedule.map_index == ti.map_index,
                         TaskReschedule.try_number == first_try_number,
-                    )
+                        )

Review Comment:
   This looks like an "whitespace-uuups"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to