potiuk commented on code in PR #44646:
URL: https://github.com/apache/airflow/pull/44646#discussion_r1872781630
##########
airflow/models/baseoperator.py:
##########
@@ -364,6 +364,8 @@ def wrapper(self, *args, **kwargs):
sentinel = kwargs.pop(sentinel_key, None)
if sentinel:
+ if not getattr(cls._sentinel, "callers", None):
Review Comment:
As @ashb wrote - better description + unit test would be great - there was
also a related PR that has been reported by @dabla here
https://github.com/apache/airflow/pull/44240 - and we could not figure out why
the class method would not be ine maybe we can brainstorm together why this
might be needed in this case - because essentially it should not be needed (at
least as far as we discussed there).
Maybe @ashb you have an idea ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
