jason810496 commented on code in PR #44736:
URL: https://github.com/apache/airflow/pull/44736#discussion_r1875861775
##########
airflow/api_fastapi/common/parameters.py:
##########
@@ -112,7 +112,7 @@ def depends(self, only_active: bool = True) ->
_OnlyActiveFilter:
return self.set_value(only_active)
-class _SearchParam(BaseParam[str]):
+class SearchParam(BaseParam[str]):
Review Comment:
Hi @shubhamraj-git,
From my perspective, I think `task_display_name_pattern` is not currently
used by other endpoints, so it might not be suitable to place it in common
parameters. WDYT ?
Here some related discussion
https://github.com/apache/airflow/pull/43947#issuecomment-2503874473 about
common parameters.
Additionally, some `_SearchParam` constructs in common parameters should be
refactored out ( since those only be used in one endpoint ). It seems I
overlooked this in https://github.com/apache/airflow/pull/43947 PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
