bugraoz93 commented on PR #44332:
URL: https://github.com/apache/airflow/pull/44332#issuecomment-2529694214

   > After more manual testing. It looks like we have a few issues.
   > 
   > Using the `example_task_group` Dag:
   > 
   > * `section_1` is correct if everything runs normally. But manually mark a 
child task as failed. Then the `states` dict is correct but overall_state was 
not updated
   > * `section_2` the `task_count` is correct at 2 if you assume its nested 
task group is a single task but the list of `states` shows 4 states which would 
be correct if you ignore task groups and only count the actual number of tasks 
no matter how nested they may be.
   
   Thanks a lot for the review and additional tests! 
   I have adjusted the code accordingly. Indeed it was missing recursive 
`task_groups` and `overall_state` calculation had problem with the order of the 
loops :sweat_smile: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to