kaxil commented on code in PR #44818:
URL: https://github.com/apache/airflow/pull/44818#discussion_r1878385270
##########
airflow/dag_processing/manager.py:
##########
@@ -1146,8 +1077,8 @@ def _collect_results_from_processor(self, processor,
session: Session = NEW_SESS
span.end(end_time=datetime_to_nano(last_finish_time))
- Stats.timing(f"dag_processing.last_duration.{file_name}",
last_duration)
- Stats.timing("dag_processing.last_duration", last_duration,
tags={"file_name": file_name})
+ Stats.timing(f"dag_processing.last_duration.{file_name}",
last_duration * 1000.0)
+ Stats.timing("dag_processing.last_duration", last_duration * 1000.0,
tags={"file_name": file_name})
Review Comment:
Does this change the unit for stats?
Oh welp no, we are defaulting to seconds -- converting to ms here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
