kaxil commented on code in PR #44820:
URL: https://github.com/apache/airflow/pull/44820#discussion_r1878636593
##########
airflow/models/taskinstance.py:
##########
@@ -1011,7 +1011,6 @@ def get_triggering_events() -> dict[str, list[AssetEvent
| AssetEventPydantic]]:
# * KNOWN_CONTEXT_KEYS in airflow/utils/context.py
# * Table in docs/apache-airflow/templates-ref.rst
context: dict[str, Any] = {
- "conf": conf,
Review Comment:
imo it is related but a separate discussion: the focus of this one is very
limited to only the Task Context dictionary. This is actually good since there
will be only one way to get configuration i.e. importing airflow.configuration
object instead of this other way -- more so because there is still some way to
go in determining (2) or (3)
Check my reply here:
https://lists.apache.org/thread/z5wb4jdwzowwv3v7z8ck8nrwlrzlz187
Mainly because regardless of whatever we decide - there isn't a good reason
to keep this in the Task Context dictionary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
