(airflow) branch main updated: Add notes to the Trigger Dag UI form (#44822)

[jscheffl]

This is an automated email from the ASF dual-hosted git repository.

jscheffl pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new 3cf6b5393ba Add notes to the Trigger Dag UI form (#44822)
3cf6b5393ba is described below

commit 3cf6b5393bad30497218482ba909bbf06fac6c20
Author: Shubham Raj <48172486+shubhamraj-...@users.noreply.github.com>
AuthorDate: Wed Dec 11 11:57:53 2024 +0530

    Add notes to the Trigger Dag UI form (#44822)
    
    * add notes
    
    * reviews
    
    * add dag run notes
    
    Co-authored-by: Jens Scheffler <95105677+jsche...@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Jens Scheffler <95105677+jsche...@users.noreply.github.com>
---
 airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx  | 13 ++++++++++++-
 airflow/ui/src/components/TriggerDag/TriggerDAGModal.tsx |  1 +
 airflow/ui/src/components/TriggerDag/TriggerDag.tsx      |  1 +
 3 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx 
b/airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx
index 0844294f8b3..9df1f208ed8 100644
--- a/airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx
+++ b/airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx
@@ -157,7 +157,7 @@ const TriggerDAGForm: React.FC<TriggerDAGFormProps> = ({
                 render={({ field }) => (
                   <Input
                     {...field}
-                    placeholder="Run id, optional - will be generated if not 
provided"
+                    placeholder="Run Id, optional - will be generated if not 
provided"
                     size="sm"
                   />
                 )}
@@ -204,6 +204,17 @@ const TriggerDAGForm: React.FC<TriggerDAGFormProps> = ({
                   </Box>
                 )}
               />
+
+              <Text fontSize="md" mb={2} mt={6}>
+                Dag Run Notes
+              </Text>
+              <Controller
+                control={control}
+                name="notes"
+                render={({ field }) => (
+                  <Input {...field} placeholder="Optional" size="sm" />
+                )}
+              />
             </Box>
           </Accordion.ItemContent>
         </Accordion.Item>
diff --git a/airflow/ui/src/components/TriggerDag/TriggerDAGModal.tsx 
b/airflow/ui/src/components/TriggerDag/TriggerDAGModal.tsx
index ae90f112bfb..e4b946fd41f 100644
--- a/airflow/ui/src/components/TriggerDag/TriggerDAGModal.tsx
+++ b/airflow/ui/src/components/TriggerDag/TriggerDAGModal.tsx
@@ -47,6 +47,7 @@ const TriggerDAGModal: React.FC<TriggerDAGModalProps> = ({
       dagId,
       dataIntervalEnd: "",
       dataIntervalStart: "",
+      notes: "",
       runId: "",
     }),
     [dagId],
diff --git a/airflow/ui/src/components/TriggerDag/TriggerDag.tsx 
b/airflow/ui/src/components/TriggerDag/TriggerDag.tsx
index 70890ad526f..48f5755ba0d 100644
--- a/airflow/ui/src/components/TriggerDag/TriggerDag.tsx
+++ b/airflow/ui/src/components/TriggerDag/TriggerDag.tsx
@@ -22,6 +22,7 @@ export type DagParams = {
   dagId: string;
   dataIntervalEnd: string;
   dataIntervalStart: string;
+  notes: string;
   runId: string;
 };