dabla commented on PR #44675:
URL: https://github.com/apache/airflow/pull/44675#issuecomment-2533943215

   > Just want to check, right now several of the existing operators get a 
handle to the connection and call the Microsoft Azure library directly. These 
should really be refactored down into the hook as well, right? For example 
this: 
https://github.com/apache/airflow/blob/main/providers/src/airflow/providers/microsoft/azure/operators/asb.py#L316-L339
   
   Good catch, indeed it would be better that this code resides within the 
hook, the hook should take care of the connection handling and exposes the 
logic within a public method which on it's turn is called from the operator, 
that way the same operation can also be executed from the hook within a 
PythonOperator.
   
   But don't worry, there are still a lot of operators written that way 
unfortunately, but if we clean up every time we need to modify an operator, we 
will get there one day :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to