kaxil commented on code in PR #44839:
URL: https://github.com/apache/airflow/pull/44839#discussion_r1880066065
##########
airflow/dag_processing/manager.py:
##########
@@ -557,36 +490,16 @@ def _run_parsing_loop(self):
self.log.debug("Received %s signal from
DagFileProcessorAgent", agent_signal)
if agent_signal == DagParsingSignal.TERMINATE_MANAGER:
- if span.is_recording():
- span.add_event(name="terminate")
self.terminate()
break
elif agent_signal == DagParsingSignal.END_MANAGER:
- if span.is_recording():
- span.add_event(name="end")
self.end()
sys.exit(os.EX_OK)
- elif agent_signal == DagParsingSignal.AGENT_RUN_ONCE:
- # continue the loop to parse dags
- pass
elif isinstance(agent_signal, CallbackRequest):
self._add_callback_to_queue(agent_signal)
else:
raise ValueError(f"Invalid message
{type(agent_signal)}")
- if not ready and not self._async_mode:
Review Comment:
Do we still need the "ready" check? (I haven't dug into why that was needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
