amoghrajesh commented on code in PR #44843:
URL: https://github.com/apache/airflow/pull/44843#discussion_r1880389663
##########
task_sdk/src/airflow/sdk/execution_time/comms.py:
##########
@@ -170,13 +170,17 @@ class PutVariable(BaseModel):
type: Literal["PutVariable"] = "PutVariable"
+"""Defines the types that the RTIF payload's dictionary values can take. These
are all JsonAble types """
+JsonAbleValueTypes = Union[str, dict[str, str], list[str], int, float, None]
Review Comment:
We shouldn't be adding tuple and set because those will be taken care by our
internal serialisation helper:
https://github.com/apache/airflow/blob/main/airflow/serialization/helpers.py#L28.
This will not ever return a set or tuple. When we introduce templating in TASK
sdk, this should be handled there imo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
