uranusjr commented on code in PR #44836:
URL: https://github.com/apache/airflow/pull/44836#discussion_r1881384167
##########
tests/jobs/test_scheduler_job.py:
##########
@@ -6319,10 +6319,10 @@ def
test_activate_referenced_assets_with_no_existing_warning(self, session):
)
)
assert dag_warning.message == (
- 'Cannot activate asset AssetModel(name="it\'s also a duplicate",'
- " uri='s3://bucket/key/1', extra={'foo': 'bar'}); uri is already
associated to 'asset1'\n"
- "Cannot activate asset AssetModel(name='asset1', uri"
- "=\"it's duplicate\", extra={'foo': 'bar'}); name is already
associated to 's3://bucket/key/1'"
+ 'Cannot activate asset Asset(name="it\'s also a duplicate",'
+ " uri='s3://bucket/key/1', group='asset', extra={'foo': 'bar'},
watchers=[]); uri is already associated to 'asset1'\n"
Review Comment:
I think this is too much. `name` and `uri` are obviously required; group is
_probably_ useful, but the rest are likely not useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
