kaxil commented on code in PR #44533: URL: https://github.com/apache/airflow/pull/44533#discussion_r1884306043
########## airflow/migrations/versions/0052_3_0_0_remove_pickled_data_from_dagrun_table.py: ########## @@ -0,0 +1,73 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +remove pickled data from dagrun table. + +Revision ID: e39a26ac59f6 +Revises: 038dc8bc6284 +Create Date: 2024-12-01 08:33:15.425141 + +""" + +from __future__ import annotations + +import sqlalchemy as sa +from alembic import op +from sqlalchemy import text +from sqlalchemy.dialects import postgresql + +# revision identifiers, used by Alembic. +revision = "e39a26ac59f6" +down_revision = "038dc8bc6284" +branch_labels = None +depends_on = None +airflow_version = "3.0.0" + + +def upgrade(): + """Apply remove pickled data from dagrun table.""" + conn = op.get_bind() + + # Update the dag_run.conf column value to NULL + conn.execute(text("UPDATE dag_run set conf=null WHERE conf IS NOT NULL")) + + conf_type = sa.JSON().with_variant(postgresql.JSONB, "postgresql") + + with op.batch_alter_table("dag_run", schema=None) as batch_op: + # Drop the existing column for SQLite (due to its limitations) + batch_op.drop_column("conf") Review Comment: Do we need to set conf=null, if we are going to drop that column anyway? ########## airflow/migrations/versions/0052_3_0_0_remove_pickled_data_from_dagrun_table.py: ########## @@ -0,0 +1,73 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +remove pickled data from dagrun table. + +Revision ID: e39a26ac59f6 +Revises: 038dc8bc6284 +Create Date: 2024-12-01 08:33:15.425141 + +""" + +from __future__ import annotations + +import sqlalchemy as sa +from alembic import op +from sqlalchemy import text +from sqlalchemy.dialects import postgresql + +# revision identifiers, used by Alembic. +revision = "e39a26ac59f6" +down_revision = "038dc8bc6284" +branch_labels = None +depends_on = None +airflow_version = "3.0.0" + + +def upgrade(): + """Apply remove pickled data from dagrun table.""" + conn = op.get_bind() + + # Update the dag_run.conf column value to NULL + conn.execute(text("UPDATE dag_run set conf=null WHERE conf IS NOT NULL")) + + conf_type = sa.JSON().with_variant(postgresql.JSONB, "postgresql") + + with op.batch_alter_table("dag_run", schema=None) as batch_op: + # Drop the existing column for SQLite (due to its limitations) + batch_op.drop_column("conf") Review Comment: Worth for you to take a look too @jedcunningham @ephraimbuddy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
