kaxil commented on code in PR #44954:
URL: https://github.com/apache/airflow/pull/44954#discussion_r1888513070
##########
task_sdk/tests/execution_time/test_supervisor.py:
##########
@@ -862,6 +862,14 @@ def watched_subprocess(self, mocker):
"",
id="patch_task_instance_to_skipped",
),
+ pytest.param(
+ TaskState(state=TerminalTIState.FAILED,
end_date=timezone.parse("2024-10-31T12:00:00Z")),
+ b"",
+ "",
+ (),
+ "",
+ id="patch_task_instance_to_failed",
+ ),
Review Comment:
Don't think we need this since it is already covered by `TaskState` via --
since all we need to check is it can handle `TaskState` msg:
```
TaskState(state=TerminalTIState.SKIPPED,
end_date=timezone.parse("2024-10-31T12:00:00Z")),
```
##########
task_sdk/tests/execution_time/test_supervisor.py:
##########
@@ -862,6 +862,14 @@ def watched_subprocess(self, mocker):
"",
id="patch_task_instance_to_skipped",
),
+ pytest.param(
+ TaskState(state=TerminalTIState.FAILED,
end_date=timezone.parse("2024-10-31T12:00:00Z")),
+ b"",
+ "",
+ (),
+ "",
+ id="patch_task_instance_to_failed",
+ ),
Review Comment:
Don't think we need this since it is already covered by `TaskState` via --
since all we need to check is it can handle `TaskState` msg:
```py
TaskState(state=TerminalTIState.SKIPPED,
end_date=timezone.parse("2024-10-31T12:00:00Z")),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
