kaxil commented on code in PR #45043:
URL: https://github.com/apache/airflow/pull/45043#discussion_r1891241230
##########
task_sdk/tests/execution_time/test_supervisor.py:
##########
@@ -764,7 +764,7 @@ def watched_subprocess(self, mocker):
[
pytest.param(
GetConnection(conn_id="test_conn"),
- b'{"conn_id":"test_conn","conn_type":"mysql"}\n',
+
b'{"conn_id":"test_conn","conn_type":"mysql","type":"ConnectionResult"}\n',
Review Comment:
>isn't the purpose of this test to just check if a certain kind of "message"
can be handled by the supervisor
That's correct, but we are verifying two things:
1) Supervisor can handle that message i.e. it can consume that message,
deserialize it and calls the correct "client" method
2) Supervisor serializes the response to json and we assert the expected
serialized json message that should be added to stdin
Those are also in docstrings:
https://github.com/apache/airflow/blob/3c111680a837f22659555c9b6647df40d6ead5f0/task_sdk/tests/execution_time/test_supervisor.py#L901-L905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
