pierrejeambrun commented on code in PR #45045:
URL: https://github.com/apache/airflow/pull/45045#discussion_r1892427058
##########
airflow/ui/src/components/ClearRun/ClearRunButton.tsx:
##########
@@ -48,7 +56,8 @@ const ClearRunButton = ({ dagId, dagRunId }: Props) => {
return (
<Box>
- <Button
+ <ButtonComponent
Review Comment:
> We may be able to get away with something like:
>
> ```
> <Button
> as={withText ? undefined : IconButton}
> ```
Good idea but this is not working great. Mostly because the `IconButton` add
css (center the icon, modify the background color to transparent or lightgrey
i'm not sure), and just defaulting `as` an `IconButton` does not apply this
css, rendering is the broken.
I can make this work by overriding `backgroundColor`, `_hover`, and try to
manually center, but that's a little bit hacky.
##########
airflow/ui/src/components/ClearRun/ClearRunButton.tsx:
##########
@@ -48,7 +56,8 @@ const ClearRunButton = ({ dagId, dagRunId }: Props) => {
return (
<Box>
- <Button
+ <ButtonComponent
Review Comment:
Maybe someone will find a way to improve it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
